Revision: 21734
Author: [email protected]
Date: Tue Jun 10 09:16:29 2014 UTC
Log: Reuse RelocInfo's IsPatchedDebugBreakSlotSequence()
implementation.
RelocInfo::IsPatchedDebugBreakSlotSequence() already does this assembly
check, so just reuse it in BreakLocationIterator::IsDebugBreakAtSlot(),
like the other debug ports do.
[email protected]
Review URL: https://codereview.chromium.org/321743002
Patch from Thiago Farina <[email protected]>.
http://code.google.com/p/v8/source/detail?r=21734
Modified:
/branches/bleeding_edge/src/x64/debug-x64.cc
=======================================
--- /branches/bleeding_edge/src/x64/debug-x64.cc Tue Jun 3 08:12:43 2014
UTC
+++ /branches/bleeding_edge/src/x64/debug-x64.cc Tue Jun 10 09:16:29 2014
UTC
@@ -48,7 +48,7 @@
bool BreakLocationIterator::IsDebugBreakAtSlot() {
ASSERT(IsDebugBreakSlot());
// Check whether the debug break slot instructions have been patched.
- return !Assembler::IsNop(rinfo()->pc());
+ return rinfo()->IsPatchedDebugBreakSlotSequence();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
