LGTM

On 2014/06/11 07:40:53, marja wrote:
The latest patch set matches the disallowed characters and whitespace handling
of ContentSearchUtils, even though it's pretty arbitrary regarding what
characters it allows in the URL and what not (disallows ' which is a valid URL
character, allows ^ which is not a valid URL character).

I'm not a fan of that logic as well but I guess it is safe to match existing
behavior when switching implementation and fix possible issue with the pattern
we use in a separate change if need to.


https://codereview.chromium.org/316173002/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to