Revision: 21907
Author: [email protected]
Date: Mon Jun 23 05:50:06 2014 UTC
Log: Add missing map check to optimized f.apply(...)
This is a cutdown version of https://codereview.chromium.org/346473002/,
which aimed to fix f.call and f.apply. Optimized f.call was removed by
r21887, this is what was left.
BUG=386034
LOG=N
[email protected]
Review URL: https://codereview.chromium.org/348623002
http://code.google.com/p/v8/source/detail?r=21907
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-386034.js
Modified:
/branches/bleeding_edge/src/hydrogen.cc
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-386034.js Mon Jun
23 05:50:06 2014 UTC
@@ -0,0 +1,19 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function f(x) {
+ var v = x;
+ for (i = 0; i < 1; i++) {
+ v.apply(this, arguments);
+ }
+}
+
+function g() {}
+
+f(g);
+f(g);
+%OptimizeFunctionOnNextCall(f);
+assertThrows(function() { f('----'); }, TypeError);
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Fri Jun 20 08:40:11 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen.cc Mon Jun 23 05:50:06 2014 UTC
@@ -8564,10 +8564,12 @@
HValue* function = Pop(); // f
Drop(1); // apply
+ HValue* checked_function = AddCheckMap(function, function_map);
+
if (function_state()->outer() == NULL) {
HInstruction* elements = Add<HArgumentsElements>(false);
HInstruction* length = Add<HArgumentsLength>(elements);
- HValue* wrapped_receiver = BuildWrapReceiver(receiver, function);
+ HValue* wrapped_receiver = BuildWrapReceiver(receiver,
checked_function);
HInstruction* result = New<HApplyArguments>(function,
wrapped_receiver,
length,
@@ -8583,7 +8585,7 @@
const ZoneList<HValue*>* arguments_values = args->arguments_values();
int arguments_count = arguments_values->length();
Push(function);
- Push(BuildWrapReceiver(receiver, function));
+ Push(BuildWrapReceiver(receiver, checked_function));
for (int i = 1; i < arguments_count; i++) {
Push(arguments_values->at(i));
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
