On Mon, Jun 23, 2014 at 8:40 AM, Nico Weber <tha...@chromium.org> wrote:
> Is there any reason why the nacl bits don't use gyp_v8? > If so, I think adding this diff should make things go: Index: Makefile.nacl =================================================================== --- Makefile.nacl (revision 21943) +++ Makefile.nacl (working copy) @@ -97,7 +97,7 @@ GYP_DEFINES="${GYPENV}" \ CC=${NACL_CC} \ CXX=${NACL_CXX} \ - PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(PYTHONPATH)" \ + PYTHONPATH="$(shell pwd)/tools/generate_shim_headers:$(shell pwd)/build:$(PYTHONPATH)" \ build/gyp/gyp --generator-output="${OUTDIR}" build/all.gyp \ -Ibuild/standalone.gypi --depth=. \ -S$(suffix $(basename $@))$(suffix $@) $(GYPFLAGS) \ Could you try relanding with that? Note how generate_shim_headers is also duplicated here and in gyp_v8... > > (Why are there nacl bots on the v8 waterfall anyway?) > > > On Mon, Jun 23, 2014 at 8:24 AM, Jochen Eisinger <joc...@chromium.org> > wrote: > >> it should be back now (master restart) >> >> >> On Mon, Jun 23, 2014 at 5:23 PM, Nico Weber <tha...@chromium.org> wrote: >> >>> Bleh, now that I have a keyboard and a screen, >>> http://build.chromium.org/p/client.v8/builders/NaCl%20V8%20Linux/builds/2267/steps/compile/logs/stdio >>> is down :-/ >>> >>> >>> On Mon, Jun 23, 2014 at 6:21 AM, Nico Weber <tha...@chromium.org> wrote: >>> >>>> Probably needs a `sys.path.insert (1, /path/to/v8/too)` (see >>>> gyp_chromium) >>>> On Jun 23, 2014 1:50 AM, <joc...@chromium.org> wrote: >>>> >>>>> On 2014/06/23 at 08:20:01, jochen wrote: >>>>> >>>>>> Committed patchset #1 manually as r21909 (presubmit successful). >>>>>> >>>>> >>>>> broke nacl build... >>>>> http://build.chromium.org/p/client.v8/builders/NaCl%20V8% >>>>> 20Linux/builds/2267/steps/compile/logs/stdio >>>>> >>>>> https://codereview.chromium.org/346643002/ >>>>> >>>> >>> >> > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.