2011/1/4 Søren Gjesse <[email protected]> > Why do you want to add this option to v8.gyp? lease explain as I would have > expected this option to be handled in each dependent target like Chromium > where the actual V8 to use should be defined. >
v8.gyp is referenced in many places, see http://codesearch.google.com/codesearch?as_q=v8.gyp&btnG=Search+Code&hl=en&vert=chromium&filesuggest=&as_lang=&as_filename=&as_class=&as_function=&as_case= It seems easier to make the change just in v8.gyp, and not all the places where it is referenced. For an example of the second approach, see Debian's patch at http://patch-tracker.debian.org/patch/series/view/chromium-browser/7.0.544.0~r61416-1/system_v8.patch. Note: it also changes how v8's headers are #included. For now I'm not going to change that. By the way, the change is not complicated at all. For now Gentoo just replaces the entire gyp file, see http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/www-client/chromium/files/v8.gyp?revision=1.1&view=markup. For upstreaming, I'd just make a conditional block (if use_system_v8 then the current targets would be used, otherwise the -lv8 targets from Gentoo's v8.gyp). > How is this handled by other libraries used by e.g. Chromium? > See use_system_sqlite in http://src.chromium.org/viewvc/chrome/trunk/src/third_party/sqlite/sqlite.gyp?revision=68531&view=markup, use_system_icu in http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu42/icu.gyp?revision=69864&view=markupand use_system_libevent in http://src.chromium.org/viewvc/chrome/trunk/src/third_party/libevent/libevent.gyp?revision=39362&view=markup -- v8-users mailing list [email protected] http://groups.google.com/group/v8-users
