Yeah, I agree that this should use "open" instead of "file". Note, however,
that http://docs.python.org/library/functions.html#file says that using
open() is "preferable", but not required.

As for the process how to contribute, check out
https://code.google.com/p/v8/wiki/Contributing .


On Sat, Jun 16, 2012 at 1:44 AM, Nicolai Willems <niwi...@gmail.com> wrote:

> Hello
>
> I was a bit in doubt how I should report this issue(maybe this should go
> to the contributors list?). But I found a minor thing in one of the build
> scripts:
>
> http://code.google.com/p/v8/source/browse/branches/bleeding_edge/tools/gen-postmortem-metadata.py#434
>
> Says
>         out = file(sys.argv[1], 'w');
> Should
>         out = open(sys.argv[1], 'w');
>
> I hope this helps. I would be happy to commit/send something, but for now
> I'm a bit in doubt about how.
>
> /Nicolai Willems
>
>

-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users

Reply via email to