[-v8-dev,+v8-users] What are the errors that the tool reports? (Devs on the team see no errors from presubmit script)
Thanks, Dmitry On Mon, Feb 24, 2014 at 2:13 PM, Alexis Campailla <ale...@janeasystems.com>wrote: > I am trying to upload a patch for the first time. I just checked out a > fresh copy of the master branch using Git. I followed these instructions: > https://code.google.com/p/v8/wiki/UsingGit and then applied my small > change in a new branch. > > > > When trying to upload the patch with git cl upload, the presubmit checks > fail and the patch doesn’t get uploaded. > > > > The tool is complaining about 122 errors in C++ lint checks. I did not > however touch these files. What am I doing wrong? > > > > Thanks in advance. > > > > Total errors found: 122 > > Total violating files: 0 > > > > ** Presubmit Messages ** > > Missing OWNER reviewers for these files: > > src\bootstrapper.cc > > src\isolate.h > > > > Suggested OWNERS: (Use "git-cl owners" to interactively select owners.) > > …@chromium.org > > > > ** Presubmit ERRORS ** > > C++ lint check failed > > -- > -- > v8-dev mailing list > v8-...@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
