Problem then, it should take no more than a second or two. Basically it is a "this should not hang the engine" test. On Sep 26, 2014 9:56 AM, "Jakob Kummerow" <jkumme...@chromium.org> wrote:
> On Fri, Sep 26, 2014 at 3:18 PM, Isiah Meadows <impinb...@gmail.com> > wrote: > >> >> >> On Thursday, September 25, 2014 2:01:03 PM UTC-4, Jakob Kummerow wrote: >>> >>> That depends entirely on the kind of performance delta we're talking >>> about. >>> >>> If a particular testcase went from actually hanging (endless loop, or >>> running for hours) to finishing quickly (say, in 1 millisecond), then by >>> all means land that testcase. (You don't have to detect the hang yourself, >>> the test driver already has a timeout for each test.) >>> >> >> Okay. That's pretty much what I needed. My test case would be for the >> former case there (actually hanging). I was more looking for a specific >> case that shouldn't hang. How long is the timeout? >> > > It's chosen dynamically based on a variety of factors, IIRC between a > couple seconds and a few minutes. Do not depend on it. Make sure your > testcase finishes fast (1 millisecond is a good target to aim for). > > -- > -- > v8-users mailing list > v8-users@googlegroups.com > http://groups.google.com/group/v8-users > --- > You received this message because you are subscribed to a topic in the > Google Groups "v8-users" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/v8-users/AMVUNpV-xLw/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > v8-users+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
