LGTM3 On Fri, Jun 19, 2020 at 6:50 AM Manuel Rego Casasnovas <r...@igalia.com> wrote:
> LGTM2 > > On 19/06/2020 15:30, Yoav Weiss wrote: > > LGTM1 as this is catching up with Firefox and Safari. > > > > On Tue, Jun 16, 2020 at 5:54 PM 'Thibaud Michaud' via blink-dev > > <blink-...@chromium.org <mailto:blink-...@chromium.org>> wrote: > > > > Contact emails > > > > thiba...@chromium.org <mailto:thiba...@chromium.org>, > > ecmzieg...@chromium.org <mailto:ecmzieg...@chromium.org> > > > > > > Spec > > > > WebAssembly multi-value spec repository: > > > > https://github.com/WebAssembly/multi-value/ > > > > Recently merged into the core WebAssembly spec repository: > > > > https://github.com/WebAssembly/spec/ > > > > > > Summary > > > > The WebAssembly multi-value feature allows WebAssembly functions and > > blocks to consume and return an arbitrary number of values. They > > were previously limited to returning 0 or 1 value, and blocks were > > not allowed to consume values. JavaScript functions returning > > iterables can be imported as multi-value functions in WebAssembly, > > and multi-value WebAssembly functions can be exported as functions > > returning arrays to JavaScript. > > > > > > Is this feature supported on all six Blink platforms (Windows, Mac, > > Linux, Chrome OS, Android, and Android WebView)? > > > > Yes. > > > > > > Risks > > > > Interoperability and Compatibility > > > > The feature specification is finished > > < > https://github.com/WebAssembly/proposals/blob/master/finished-proposals.md > > and > > merged into the core WebAssembly spec > > <https://github.com/WebAssembly/spec>. It is already enabled by > > default in Firefox > > <https://bugzilla.mozilla.org/show_bug.cgi?id=1628321> and in WebKit > > <https://bugs.webkit.org/show_bug.cgi?id=202250>. > > > > > > Is this feature fully tested by web-platform-tests > > < > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md > >? > > > > The feature is tested by the V8 test suite, which includes the > > WebAssembly spec tests > > <https://github.com/WebAssembly/spec/tree/master/test> and > > additional JavaScript tests > > < > https://cs.chromium.org/chromium/src/v8/test/mjsunit/wasm/multi-value.js>. > > > > > > Entry on the feature dashboard <http://www.chromestatus.com/> > > > > https://chromestatus.com/features/5192420329259008 > > > > > > *Requesting approval to ship?* > > Yes. > > > > -- > > You received this message because you are subscribed to the Google > > Groups "blink-dev" group. > > To unsubscribe from this group and stop receiving emails from it, > > send an email to blink-dev+unsubscr...@chromium.org > > <mailto:blink-dev+unsubscr...@chromium.org>. > > To view this discussion on the web visit > > > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALowwNZ7C_F183%2Bb1QVuNuCfJnmBAJyz7Rh2RegZ9W1dq%2BsEWA%40mail.gmail.com > > < > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CALowwNZ7C_F183%2Bb1QVuNuCfJnmBAJyz7Rh2RegZ9W1dq%2BsEWA%40mail.gmail.com?utm_medium=email&utm_source=footer > >. > > > > -- > > You received this message because you are subscribed to the Google > > Groups "blink-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to blink-dev+unsubscr...@chromium.org > > <mailto:blink-dev+unsubscr...@chromium.org>. > > To view this discussion on the web visit > > > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEjdj_GeaW3Lcf2MM9sCAER%3D8R-TzYyt-oGt36AyTz4syg%40mail.gmail.com > > < > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CACj%3DBEjdj_GeaW3Lcf2MM9sCAER%3D8R-TzYyt-oGt36AyTz4syg%40mail.gmail.com?utm_medium=email&utm_source=footer > >. > > -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion on the web visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/a4523859-b463-f8b8-a1e4-9e3212080e45%40igalia.com > . > -- -- v8-users mailing list v8-users@googlegroups.com http://groups.google.com/group/v8-users --- You received this message because you are subscribed to the Google Groups "v8-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-users+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-users/CAOMQ%2Bw-8%2BjvDD%2BgMVuT0SV9Bm0tAm29YniJS_VSSKVDYA1AEdw%40mail.gmail.com.
