Author: sewardj
Date: 2008-03-04 19:42:28 +0000 (Tue, 04 Mar 2008)
New Revision: 7563
Log:
Disable the last-lock-lossage mechanism. It can be very slow with
MSMProp1, and there have been multiple reports of it generating
confusing results.
Modified:
branches/HGDEV/helgrind/hg_main.c
Modified: branches/HGDEV/helgrind/hg_main.c
===================================================================
--- branches/HGDEV/helgrind/hg_main.c 2008-03-04 19:11:38 UTC (rev 7562)
+++ branches/HGDEV/helgrind/hg_main.c 2008-03-04 19:42:28 UTC (rev 7563)
@@ -1336,7 +1336,7 @@
SegmentSet ss = get_SHVAL_SS(sv);
LockSet ls = get_SHVAL_LS(sv);
UWord n_segments = SS_get_size(ss);
- int n_locks = HG_(cardinalityWS)(univ_lsets, ls);
+ Int n_locks = HG_(cardinalityWS)(univ_lsets, ls);
VG_(sprintf)(buf, "%c #SS=%d #LS=%d ",
is_w ? 'W' : 'R', n_segments, n_locks);
@@ -1348,7 +1348,7 @@
}
S = SS_get_element(ss, i);
VG_(sprintf)(buf + VG_(strlen)(buf), "S%d/T%d ",
- (int)S, SEG_get(S)->thr->errmsg_index);
+ (Int)S, SEG_get(S)->thr->errmsg_index);
}
} else {
VG_(sprintf)(buf, "Invalid-shadow-word(%u)", sv);
@@ -3142,7 +3142,9 @@
if (oldLS != newLS) {
// if the lockset changed, remember when it happened
- record_last_lock_lossage(a, oldLS, newLS);
+ if (0) // FIXME. Do we want this functionality? If so,
+ // it can be very slow.
+ record_last_lock_lossage(a, oldLS, newLS);
}
goto done;
}
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Valgrind-developers mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/valgrind-developers
