On Wed, 3 Sep 2025 11:28:38 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> No, because the old code is wrong - the flags are no-ops if the class file >> version is not latest release's preview (by default it is latest release.0) > > Ok, but then shouldn't this add both ACC_IDENTITY and ACC_SUPER and leave it > to the API to decide what to emit based on version? ACC_ ones are bit masks, and distinguishing them is meaningless. AccessFlag.IDENTITY and AccessFlag.SUPER are the actual differing ones. Validation of access flags by version requires somewhat invasive changes to the ClassFile API, so is not included in this patch. Reminder, this class building is completely in non-preview. There is no point talking about identity here. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/1533#discussion_r2319129713
