On Thu, 4 Sep 2025 01:57:09 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
> I added some logging and fixed the tests so that one doesn't rely on a
> migrated class in java.base to throw a VerifyError (will make a parallel fix
> to this test in mainline). The other, I changed the logging message that it
> is looking for. More tests in this area will be added.
> Tested locally.
src/hotspot/share/classfile/classFileParser.cpp line 6234:
> 6232: // Just poking the system dictionary to see if the class has
> already be loaded. Looking for migrated classes
> 6233: // used when --enable-preview when jdk isn't compiled with
> --enable-preview so doesn't include LoadableDescriptors.
> 6234: // This is temporary.
I was talking to Simms earlier and we think we should have a classfile check
(i.e. ensure we are running whatever major + preview we are on at the moment),
and then disable the whole loadabledescriptor functionality if the version
doesn't match up. When we do this, we should probably consider that here as
well. What do you think?
src/hotspot/share/classfile/classFileParser.cpp line 6240:
> 6238:
> _inline_layout_info_array->adr_at(fieldinfo.index())->set_klass(InlineKlass::cast(klass));
> 6239: log_info(class, preload)("Preloading of class %s during
> loading of class %s "
> 6240: "(cause: field type not in
> LoadableDescriptors attribute) succeeded",
"field type not in LoadableDescriptors" yet "succeeded" seems contradictory.
Correct me if I'm wrong, but I think successful preloading implies that this
class was (potentially transitively) in a LoadableDescriptors attribute of some
class being loaded.
I'm not sure I follow why we suddenly introduce a log message here which is
never checked in the tests. Could you elaborate?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1544#discussion_r2321981517
PR Review Comment:
https://git.openjdk.org/valhalla/pull/1544#discussion_r2322025202
