On Mon, 16 Mar 2026 16:30:26 GMT, Damon Fenacci <[email protected]> wrote:
> # Issue
> Many AppCDS test asserts with `assert(false) failed: Address
> 0x00007f0dfc2923e0 for <unknown>/('verify_oop: r11: broken oop oop_result,
> "broken oop in call_VM_base"
> (src/hotspot/cpu/x86/macroAssembler_x86.cpp:1353)') is missing in AOT Code
> Cache addresses table` when run with `-Xcomp --enable-preview`
>
> # Cause
> The crash happens during AOT cache dumping seemingly because
> `-XX:+VerifyOops` causes the adapter to use addresses that the AOT doesn't
> know about. In particular, `verify_oop`/`verify_oop_addr` add a message
> C‑string and reference the verify‑oop stub entry.
> `AOTCodeCache::write_relocations()` tries to serialize those relocations,
> `AOTCodeAddressTable::id_for_address()` can’t resolve them and crashes.
> In this case the issue happens with `--enable-preview` because it creates an
> adapter for scalarized arguments and, after creating the oop from the
> arguments, `get_vm_result_oop` invokes `verify_oop_msg`. Without
> `--enable-preview` the path is never taken and the missing "registration"
> isn’t exercised (I fear that this crash could potentially be triggered by
> some other (non preview) code but the fix doesn't need to distinguish between
> preview/non-preview).
>
> # Fix
> Apparently we need to make the two addresses used by `verify_oop_msg`
> "visible" to AOT: register the debug message string and add
> `StubRoutines::verify_oop_subroutine_entry_address()` to the AOT “extrs”
> table.
>
> # Testing
> Tier 1-3+
> Failing CDS tests before and after
The fix is correct. Good work.
We actually disable AOT code generation when VerifyOops is on. It produces a
lot of C strings and we have only fixed number of slots (500 in debug VM) to
record them.
If you can manually run locally test, please run with
`-Xlog:aot+codecache+exit=debug` it will show (among other things) how many C
strings were recorded in AOT cache during `-XXAOTMode=record` phase:
[3.139s][debug][aot,codecache,exit] Wrote 1 C strings of total length 22
I don't want to hit 500 limit.
-------------
PR Review:
https://git.openjdk.org/valhalla/pull/2233#pullrequestreview-4007877011
