On Thu, 26 Mar 2026 19:15:52 GMT, Daniel D. Daugherty <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> cleanup/lworld-vh-gen >> - typo >> - Remove debug output >> - More debug >> - Stage > > make/modules/java.base/gensrc/GensrcVarHandles.gmk line 69: > >> 67: # Only plain access for non-atomic storage >> 68: $1_KEYS += NonPlainAccess >> 69: endif > > Should the `ifeq` be `ifneq` since I think you are testing for the presence > of NonAtomic stuff here? > > The comment on L67 doesn't match the code on L68: `# Only plain access` > versus `+= NonPlainAccess`. Yep, that's a typo in my template. I should renme this prop to nonatomic. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2265#discussion_r2997232554
