On Mon, 30 Mar 2026 13:03:48 GMT, Paul Hübner <[email protected]> wrote:
>> Hi all,
>>
>> This change eliminates more box cache usages when running with
>> `--enable-preview`:
>> * The majority of the change is contributed by @xmas92 who disabled CDS
>> loading an archived cache.
>> * There's an autobox cache cast in C2 that needed to be disabled.
>>
>> Notably, this change does not prevent the `XXXCache`'s `cache` variables
>> from being CDS archived. This is due to the fact that the infrastructure is
>> common to preview and non-preview mode, and the code complexity is not
>> justifiable when the cost is storing five `null`s. Instead, it is ensured
>> that the cache is never read from.
>>
>> Testing: tiers 1-4.
>
> Paul Hübner has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Move autobox check to ciField.
Changes requested by liach (Committer).
src/java.base/share/classes/java/lang/Byte.java line 182:
> 180: if (ByteCache.isEnabled()) {
> 181: final int offset = 128;
> 182: return ByteCache.cache[(int)b + offset];
I think the introduction of `XxxCache.isEnabled` and all the changes to
`valueOf` methods are redundant.
-------------
PR Review:
https://git.openjdk.org/valhalla/pull/2249#pullrequestreview-4030891563
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2249#discussion_r3010073944
