On Mon, 30 Mar 2026 17:10:19 GMT, Matias Saavedra Silva <[email protected]>
wrote:
>> Paul Hübner has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move autobox check to ciField.
>
> src/hotspot/share/cds/heapShared.cpp line 123:
>
>> 121: static const char* _archived_cache_name = "archivedCache";
>> 122: static ArchivableStaticFieldInfo archive_subgraph_entry_fields[] = {
>> 123: {"java/lang/Integer$IntegerCache", _archived_cache_name},
>
> I don't think this change is necessary, we should avoid unneeded diffs if
> possible.
It's used to re-use `_archived_cache_name` in the new assertion later on. Would
you like me to revert this assertion?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2249#discussion_r3014242964
