On Tue, 31 Mar 2026 09:36:38 GMT, Tobias Hartmann <[email protected]> wrote:
>> Roland Westrelin has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 26 commits: >> >> - more >> - Merge branch 'lworld' into JDK-8372268 >> - Merge branch 'lworld' into JDK-8372268 >> - review >> - Update src/hotspot/share/runtime/signature.hpp >> >> Co-authored-by: Tobias Hartmann <[email protected]> >> - whitespaces >> - test tweaks >> - more >> - aarch64 >> - more >> - ... and 16 more: >> https://git.openjdk.org/valhalla/compare/7ed0bd92...8f90a9f6 > > src/hotspot/share/opto/compile.cpp line 2003: > >> 2001: } else if (u->is_CallJava()) { >> 2002: CallJavaNode* call = u->as_CallJava(); >> 2003: if (call->method() != nullptr && >> call->method()->get_Method()->mismatch()) { > > Do we need a `call->method() != nullptr` check in lines 2009 and 2040 as well? You're right, it looks safer. Can you have a look at the new commit? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2062#discussion_r3016485183
