> Hi everyone, > > The test `InlineTypeDensity.java` builds on incorrect assumptions that a null > restricted non-atomic value class is identical to a primitive type, which is > not necessarily the case. For example, the first element of an array has to > be aligned to 64 bits, while in a primitive type it does not. With COH > enabled, this causes the test to fail, as the value class becomes bigger than > its primitive equivalent. > > I have reworked this test to instead check that everything is flattened as > expected, and that the alignment of the first element is correctly 64 bits. > With these changes, I have also removed `vm.flagless` which makes us able to > run this test in more configurations. > > Testing: > - Tiers 1-3 > - Manual runs of the test with different flag combinations.
Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision: changed test functions to private ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/2295/files - new: https://git.openjdk.org/valhalla/pull/2295/files/4447566e..ace6c151 Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2295&range=01 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2295&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/valhalla/pull/2295.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2295/head:pull/2295 PR: https://git.openjdk.org/valhalla/pull/2295
