On Thu, 16 Apr 2026 11:43:53 GMT, Quan Anh Mai <[email protected]> wrote:
>> Christian Hagedorn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> improve assert message > > src/hotspot/share/opto/macroArrayCopy.cpp line 1500: > >> 1498: // 2) src and dest do not have the same flatness. >> 1499: // 3) src or dest is a flat abstract value class array (we don't >> know the exact layout and cannot use the stub). >> 1500: // 4) dest is a flat value class array with oop fields and requires >> to emit write barriers (we don't have such a stub). > > This should be `src or dest` similar to other comments, because loading an > oop may require load barrier, too. Besides, should it be that `src` and `dest` have the same `layout_kind`, can we arraycopy a nullable array to a null-free array, or an atomic to a non-atomic array? ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2325#discussion_r3092923652
