On Fri, 17 Apr 2026 09:52:42 GMT, Axel Boldt-Christmas <[email protected]> 
wrote:

> lgtm.
> 
> I think this went unnoticed for so long (seems to have been in the code for 6 
> years) is because it is rare for GC to not have a heap address layout where 
> where some subset of bits are always `1`.
> 
> This only happens with `-UseCompressedOops`, (or with some compressed modes 
> depending on the specific base selection). With ZGC it never happened as we 
> always have a disjoint heap base.

Thanks! I've been able to reproduce wrong behaviour with 
`-XX:+UseCompressedOops` yielding base 0, shift 3 that appears to be fixed 
after this patch.

-------------

PR Comment: https://git.openjdk.org/valhalla/pull/2329#issuecomment-4267037851

Reply via email to