On Tue, 21 Apr 2026 09:55:40 GMT, Tobias Hartmann <[email protected]> wrote:
>> This patch addresses various follow-up TODOs from >> [JDK-8278390](https://bugs.openjdk.org/browse/JDK-8278390). >> >> I added PR comments to explain the changes in more detail. >> >> Thanks, >> Tobias >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Tobias Hartmann has updated the pull request incrementally with one > additional commit since the last revision: > > Reviewer comments Thanks for your answers, the PR looks good to me. src/hotspot/share/oops/inlineKlass.cpp line 232: > 230: // the first word is a tri-state value (null, tagged InlineKlass*, or > oop) and the remaining > 231: // registers carry the field values. > 232: void InlineKlass::initialize_calling_convention(TRAPS) { Thanks for the explanation, I see that below we talk about a null marker slot at scalarized return value, is it the null marker of the return value, or is it something else? If it is the null marker of the return value, it seems the tri-state of the oop is unnecessary, as we are passing the values similar to how we pass them as an argument. ------------- Marked as reviewed by qamai (Committer). PR Review: https://git.openjdk.org/valhalla/pull/2339#pullrequestreview-4146911137 PR Review Comment: https://git.openjdk.org/valhalla/pull/2339#discussion_r3116729244
