On Tue, 21 Apr 2026 08:44:38 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>> Yes, name is from a signature >> >> TempNewSymbol name = Signature::strip_envelope(sig); >> >> >> I don't think `name` and `k->name()` should ever diverge since both the >> signature and the klass from `get_inline_type_field_klass_or_null` are from >> the same "field_index" in the caller. If anything, I'd expect a stronger >> invariant, maybe with an assert, that they are the same if k is non-null. >> >> I agree that the print could do without printing the name twice, but I don't >> have anything against the current version. > > Alright. I do not think I understand exactly what it means that we fail with > preloading these classes. > > I think in both this code patch "app substituted a different version of %s" > -> "app substituted a different version" is probably a better logging. But > not relevant for this fix patch. +1 on removal of the second printing of the class name. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2344#discussion_r3117048432
