On Tue, 28 Apr 2026 13:06:19 GMT, Stefan Karlsson <[email protected]> wrote:

>> src/hotspot/share/oops/flatArrayKlass.cpp line 107:
>> 
>>> 105:   assert(MultiArray_lock->holds_lock(THREAD), "must hold lock after 
>>> bootstrapping");
>>> 106:   assert(props.is_null_restricted() || !props.is_non_atomic(),
>>> 107:          "Null-restricted nonatomic arrays are unsupported");
>> 
>> Suggestion:
>> 
>>          "Null-restricted non-atomic arrays are unsupported");
>
> To me it looks like this assert allows null-restricted non-atomic arrays. I 
> think something is missing here.

Null-restricted non-atomic arrays are supported using the F&F APIs.
The assert is there to prevent creation of nullable non-atomic arrays, which 
require final arrays that are not implemented yet.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2366#discussion_r3154367359

Reply via email to