On Fri, 1 May 2026 05:06:38 GMT, David Holmes <[email protected]> wrote:
>> Casper Norrbin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> feedback fixes
>
> src/hotspot/share/memory/heapInspection.cpp line 608:
>
>> 606: for (char* p = normalized_name; *p != '\0'; p++) {
>> 607: if (*p == '.') {
>> 608: *p = '/';
>
> This should use `JVM_SIGNATURE_DOT` and `JVM_SIGNATURE_SLASH` - though it
> makes me cringe that we have to do this ad-hoc conversion.
I didn't know these existed, but I swapped to use these now.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2375#discussion_r3181128969
