On Thu, 23 Apr 2026 11:23:32 GMT, Coleen Phillimore <[email protected]> wrote:

>> The valhalla code had refactored object allocation in TemplateTable::_new 
>> because it was called for buffering reads from flat fields.  This buffering 
>> code was moved to runtime in JDK-8375719.  Rather than refactoring OpenJDK 
>> to match this, I chose to move the object allocation code back to where it 
>> was, with the UseCompactObjectHeaders modifications.
>> 
>> Tested with tier1-3.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Coleen Phillimore has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Remove minor whitespace changes.

This looks good.  Sorry for the delay.  For some reason I thought the moved 
code was new in Valhalla, but in fact it is mostly the same code as mainline 
JDK.  There seems to be a disagreement between aarch64 and x86 on whether the 
loop should run forwards or backwards, but mainline has the same issue.

-------------

Marked as reviewed by dlong (no project role).

PR Review: 
https://git.openjdk.org/valhalla/pull/2349#pullrequestreview-4224707242

Reply via email to