On Thu, 7 May 2026 06:30:47 GMT, Axel Boldt-Christmas <[email protected]> 
wrote:

> `DEBUG_CDS_ARCHIVE` is used add logging to the archive build step generation. 
> But because it is missing one nesting level it does nothing.
> 
> Should be prefixed with `$1_$2_$3_` not just `$1_$2_`
> 
> Build.log with `DEBUG_CDS_ARCHIVE=true`:
> * Without patch 
> 
> Creating CDS archive for jdk image for server
> Using CDS flags for server: -Xmx128M -Xms128M -XX:+UseG1GC
> 
> * With patch 
> 
> Creating CDS archive for jdk image for server
> Using CDS flags for server: -Xmx128M -Xms128M -XX:+UseG1GC 
> -Xlog:aot+map*=trace:file=/scratch/aboldtch/zgc-worktrees/valhalla_review/build/linux-x64-debug/images/jdk/lib/server/classes.jsa.cdsmap:none:filesize=0
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

LGTM thanks!

-------------

Marked as reviewed by matsaave (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2403#pullrequestreview-4247656794

Reply via email to