On Fri, 8 May 2026 21:16:22 GMT, Coleen Phillimore <[email protected]> wrote:
>> src/hotspot/share/classfile/systemDictionary.cpp line 1210:
>>
>>> 1208: bool check = preload_from_null_free_field(ik, class_loader,
>>> sig, field_index, CHECK_NULL);
>>> 1209: if (!check) {
>>> 1210: ik->set_shared_loading_failed();
>>
>> Can we safely drop this failure marking?
>
> It's used for regular shared class loading so I don't think we can drop this
> shared_loading_failed marker.
Didn't realise that one was needed. I've re-added it, along with an edit to
`try_preload_from_loadable_descriptors` so we can see if we failed or not. It
now also has a new parameter that decides if failing means we call
`shared_loading_failed `.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2409#discussion_r3234232303
