On Wed, 13 May 2026 13:31:04 GMT, Marc Chevalier <[email protected]> wrote:
>> src/hotspot/share/opto/library_call.cpp line 4781: >> >>> 4779: } >>> 4780: #endif >>> 4781: init_val = _gvn.transform(new >>> CheckCastPPNode(control(), init_val, >>> TypeOopPtr::make_from_klass(array_klass->element_klass()))); >> >> Please always remember to set the `dependency` argument of the constructors >> of `ConstraintCastNode`'s. It should only be `FloatingNarrowing` if we also >> just emit the corresponding check for that cast, otherwise, it must be >> `NonFloatingNarrowing`. > > I tihnk in this case, it should rather be `NonFloatingNarrowing`. I'm running > tests again. > > Shouldn't this argument be made non-optional if we should always set it? Yes, I think it should, I am planning to do a round of audit regarding this argument next month. The same also applies to `LoadNode`. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2432#discussion_r3234665679
