On Wed, 13 May 2026 14:22:50 GMT, Tobias Hartmann <[email protected]> wrote:
>> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestDeadInlineTypeFieldOffset.java
>> line 37:
>>
>>> 35: * @run main ${test.main.class}
>>> 36: * @run main/othervm -XX:+UnlockDiagnosticVMOptions
>>> -XX:+IgnoreUnrecognizedVMOptions
>>> 37: * -XX:+StressIGVN -XX:StressSeed=8
>>> -XX:+AlwaysIncrementalInline
>>
>> The hardcoded is on purpose? It reproduces so rarely otherwise?
>
> Yes, it's on purpose to make it reliably reproduce the issue and the usual
> way of how we design these tests. I.e. one run with fixed seed and one
> without. As we discussed offline, there are several alternatives to this
> approach, including `RepeatCompilation` etc. We decided on the current
> approach a while ago but we can surely revisit. It's out of scope of this PR
> though 🙂
>
> Testing also revealed that PreloadClasses is required to make sure that the
> `@NullRestricted` annotation is respected, so I added a corresponding
> `@requires`.
I think that means this test lacks a test that does not use a fixed seed?
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2433#discussion_r3235318518
