On Fri, 15 May 2026 12:11:32 GMT, Tobias Hartmann <[email protected]> wrote:

>> The test is rather slow and times out intermittently. On my system, the test 
>> runs for 2m 41.932s with default arguments and therefore already times out. 
>> I set the timeout to 300s to be on the safe side. I also removed the print 
>> compilation which can be re-added if needed for debugging.
>> 
>> Thanks,
>> Tobias
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Tobias Hartmann has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Removed reference to JVMCI
>  - Reviewer comments

Marked as reviewed by mchevalier (Committer).

Marked as reviewed by mchevalier (Committer).

test/hotspot/jtreg/compiler/valhalla/inlinetypes/CorrectlyRestoreRfp.java line 
52:

> 50:     static final WhiteBox WHITE_BOX = WhiteBox.getWhiteBox();
> 51:     static final int COMP_LEVEL_SIMPLE = 1; // C1
> 52:     static final int COMP_LEVEL_FULL_OPTIMIZATION = 4; // C2 or JVMCI

can the "or JVMCI" part be removed? ;)

-------------

PR Review: 
https://git.openjdk.org/valhalla/pull/2439#pullrequestreview-4297952320
PR Review: 
https://git.openjdk.org/valhalla/pull/2439#pullrequestreview-4297966383
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2439#discussion_r3248037488

Reply via email to