On Tue, 26 May 2026 08:32:42 GMT, Quan Anh Mai <[email protected]> wrote:

>> test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestLWorld.java line 4918:
>> 
>>> 4916:         Asserts.assertFalse(test174(x, null));
>>> 4917:         Asserts.assertFalse(test174(null, x));
>>> 4918:         // Asserts.assertFalse(test174(x, z));
>> 
>> Why is this needed? (Same below)
>
> Because I changed the field from an `Integer` to an `int`, so there is no 
> guarantee that `x` and `z` are different values anymore.

Ah, I missed that. Maybe add a `TODO` comment so we don't miss to re-enable 
these or add it to the `This should be Integer` comment.

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2474#discussion_r3302610340

Reply via email to