On Mon, 1 Jun 2026 13:23:36 GMT, Tobias Hartmann <[email protected]> wrote:

>> Various small code cleanups that should be self explanatory.
>> 
>> Thanks,
>> Tobias
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Tobias Hartmann has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - Revert
>  - one more

I don't even want to know how many are from me...

src/hotspot/share/oops/layoutKind.hpp line 86:

> 84: //
> 85: // IMPORTANT: The REFERENCE layout must always be associated with the 
> numerical value zero, because the implementation
> 86: // of the lava.lang.invoke.MemberName class relies on this property.

lava looks cool tho

test/hotspot/jtreg/compiler/valhalla/inlinetypes/TestMismatchHandling.jcod line 
2416:

> 2414:             ;
> 2415:             Attr(#140) { // StackMapTable
> 2416:               [] { // 

That might clash back next time we regenerate that.

-------------

Marked as reviewed by mchevalier (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2498#pullrequestreview-4401480692
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2498#discussion_r3334398381
PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2498#discussion_r3334403049

Reply via email to