On Tue, 2 Jun 2026 13:30:52 GMT, Manuel Hässig <[email protected]> wrote:

>> C1 has rudimentary conditional expression elimination and graph 
>> canonicalization. However, those optimizations on If nodes currently fold 
>> substitutability checks to pointer comparisons loosing value object 
>> semantics for acmp. This PR fixes this.
>> 
>> Testing:
>>  - [x] tier1,tier2,tier3,valhalla-comp-stress with `--enable-preview`
>> 
>> A lot of credit for this PR goes to @TobiHartmann who developed the inital 
>> fix.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Manuel Hässig has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove superfluous comments

That looks good to me.

-------------

Marked as reviewed by thartmann (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2500#pullrequestreview-4410121367

Reply via email to