On Tue, 2 Jun 2026 13:54:33 GMT, Roland Westrelin <[email protected]> wrote:

>> I propose transforming:
>> 
>> (InlineType .... (InlineType oop
>> 
>> 
>> where an `InlineType` references another `InlineType` node (maybe itself) 
>> through its `oop` input and with `Phi` or cast nodes in the subgraph in 
>> between into:
>> 
>> 
>> (InlineType .... oop
>> 
>> which requires cloning every cast or `Phi` nodes in the subgraph between the 
>> 2 `InlineType` nodes. That prevent sinfinite invocation of 
>> `PhiNode::push_inline_types_through` and cleans up the graph.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Roland Westrelin has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains 10 commits:
> 
>  - review
>  - Merge branch 'lworld' into JDK-8302217
>  - more
>  - more
>  - cleanup
>  - more
>  - more
>  - more
>  - more
>  - fix

This is hard to review but I think it's good to go. I did extensive testing and 
it's all clean.

-------------

Marked as reviewed by thartmann (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2316#pullrequestreview-4411636891

Reply via email to