On Wed, 3 Jun 2026 07:38:49 GMT, Quan Anh Mai <[email protected]> wrote:

>> Hi,
>> 
>> When `StressReachabilityFences` is `true`, the compiler tries to insert a 
>> reachability fence for all incoming states of the compilation. This misses 
>> the fact that an incoming `InlineTypeNode` may be unbuffered, so this PR 
>> fixes that by not inserting reachability fences for incoming 
>> `InlineTypeNode`s. In addition, when `reachabilityFence` is called on an 
>> `InlineTypeNode`, we need to buffer it.
>> 
>> Please take a look and leave your reviews, thanks a lot.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Quan Anh Mai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   compilation failure

That makes sense. Could you please file a follow-up tracking issue for the 
"reachability fence on value objects" discussion?

-------------

Marked as reviewed by thartmann (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2496#pullrequestreview-4417061699

Reply via email to