On Thu, 21 May 2026 21:35:36 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>> There are few places which uses the fully qualified name for the >> `AsValueClass` annotation. As a result the plugging does not modify these >> classes when compiling, so they are still identity classes. >> >> I propose improving the robustness of this plugin. We need to do this during >> parsing so we cannot actually check 100% that it will resolve to the correct >> annotation. However we can do a best effort, which handles same package, >> fully qualified, imported and rejects other annotations with the same class >> name. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Axel Boldt-Christmas has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains two additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream_valhalla/lworld' into > lworld-improve-ValueClassPlugin > - Make ValueClassPlugin more robust Just a friendly ping. The only tests that are currently being affected is `gc/stress/gcbasher`. So we are missing some EnablePreview testing here. Would be nice to get this in both for test coverage and to ensure that we do not miss future uses of `@jdk.test.lib.valueclass.AsValueClass`. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2405#issuecomment-4619951406
