On Thu, 4 Jun 2026 19:02:44 GMT, ExE Boss <[email protected]> wrote:

>> `@ValueBased` is an annotation only meaningful for concrete value classes.  
>> We should fix javac and remove the redundant annotation.
>> 
>> Apparently javac is not reading the `MIGRATED_VALUE_CLASS` flag from class 
>> files correctly. This is fine for most Java compilation jobs but affects the 
>> microbenchmark building, which I think reads from the non-preview set of 
>> classes. We can fix the reading of that flag to bypass microbenchmark 
>> building issues.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/java.base/share/classes/java/lang/Record.java line 101:
> 
>> 99:  */
>> 100: @jdk.internal.MigratedValueClass
>> 101: @jdk.internal.ValueBased
> 
> This annotation has been here since the introduction of **Records** in **JDK 
> 16**

Huh?

https://github.com/openjdk/valhalla/blob/58c9fbc93db6c27b00d1e53d7ee8bf6e382eea82/src/java.base/share/classes/java/lang/Record.java#L89-L90

-------------

PR Review Comment: 
https://git.openjdk.org/valhalla/pull/2510#discussion_r3358370953

Reply via email to