On Thu, 4 Jun 2026 16:47:43 GMT, Chen Liang <[email protected]> wrote:
>> For preview of the serialization implementation cleanup. >> >> See the mainline diff version: >> https://gist.github.com/a3440f2b9da5111fe20315e59ed17380 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Rename to Deserializer src/java.base/share/classes/java/io/ObjectStreamClass.java line 1440: > 1438: Arrays.stream(clazz.getDeclaredMethods()).filter(m -> > Modifier.isStatic(m.getModifiers())), > 1439: Arrays.stream(clazz.getDeclaredConstructors())) > 1440: .filter(m -> > m.isAnnotationPresent(DeserializeConstructor.class)) If it turns out we only use this on the wrapper constructors then I would be tempted to leave the static factory support for the code going to main line. I note your comment in the mainline PR about having flexibility but keeping unused code would be good, if possible. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2326#discussion_r3363571046
