On Mon, 8 Jun 2026 21:06:39 GMT, Dan Smith <[email protected]> wrote:

>> Suggested refinement to the find/replace filter applied for value class 
>> generation, based on my experience testing migration of some other classes.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Dan Smith has updated the pull request incrementally with four additional 
> commits since the last revision:
> 
>  - Revert "Alternate strategy: rename MigratedValueClass --> PreviewValue; 
> use it in a modifier position, then match it for text replace"
>    
>    This reverts commit cc8b7d3b1cbf21ed004d9dd282bca2305412c9c2.
>  - Revert "Missing renamed file"
>    
>    This reverts commit 1dbadaf27cf153d4fb361803c357b711fc4398d5.
>  - Reapply "Missing renamed file"
>    
>    This reverts commit 99b2be0134913b3ec7338c363c886f7779aa9009.
>  - Revert "Missing renamed file"
>    
>    This reverts commit 1dbadaf27cf153d4fb361803c357b711fc4398d5.

Looks good.

-------------

Marked as reviewed by liach (Committer).

PR Review: 
https://git.openjdk.org/valhalla/pull/2516#pullrequestreview-4453621223

Reply via email to