On Fri, 12 Jun 2026 06:09:01 GMT, Chen Liang <[email protected]> wrote:
>> 1. AccessFlag is dependent on runtime's preview feature on/off instead of >> class file version >> 2. Some new files or new changes can get some import cleanups >> 3. java.lang.reflect.Modifier changes are redundant and can be dropped >> 4. javax.lang.model.element.Modifier.VALUE belongs to VALUE_OBJECTS preview >> feature >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains four additional commits since > the last revision: > > - does does > - Merge branch 'lworld' of https://github.com/openjdk/valhalla into > clean/lw-mod-clean > - Correct defineHiddenClass BasicTest > - Random cleanup drop Marked as reviewed by alanb (no project role). test/jdk/java/lang/invoke/defineHiddenClass/BasicTest.java line 315: > 313: expectedAccessFlags |= ACC_IDENTITY; > 314: } > 315: assertEquals(hc.getModifiers(), expectedAccessFlags); Good, although probably expectedModifiers rather than expectedAccessFlags as this method returns a mask that isn't necessarily the value of the access flags from the class file. ------------- PR Review: https://git.openjdk.org/valhalla/pull/2536#pullrequestreview-4487169312 PR Review Comment: https://git.openjdk.org/valhalla/pull/2536#discussion_r3404612523
