I've taken a pass at resolving most of @erikj79's build related comments in the 
Valhalla PR:

[JDK-8317279](https://bugs.openjdk.org/browse/JDK-8317279) Standard library 
implementation of value classes and objects
https://github.com/openjdk/jdk/pull/31123

A couple of the comments will be handled by separate issues:
- [JDK-8386451](https://bugs.openjdk.org/browse/JDK-8386451) [lworld] things to 
delete from lworld just before integrating JEP-401
- [JDK-8386458](https://bugs.openjdk.org/browse/JDK-8386458) [lworld] add 
support for allowing value classes to declare native methods

In this PR, I have reverted two of @MrSimms' heap sizes of 3200 to the 
main-line's 2048.
I am testing this change with a Mach5 Tier[1-8]. Mach5 Tier[123458] have 
completed
and there are no related test or task failures. Mach5 Tier[67] are still 
executing and
are currently waiting for Mach5 resources.

Update: I have added links to the comments in JDK-8317279 that discuss my 
analysis
of the original code, where it came from and my proposed fix; gory details as 
it were.

---------
- [x] I confirm that I make this contribution in accordance with the [OpenJDK 
Interim AI Policy](https://openjdk.org/legal/ai).

-------------

Commit messages:
 - Try using the current baseline values of 2048 instead of 3200.
 - 8385743: [lworld] investigate and address build related comments in the 
Valhalla PR

Changes: https://git.openjdk.org/valhalla/pull/2541/files
  Webrev: https://webrevs.openjdk.org/?repo=valhalla&pr=2541&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8385743
  Stats: 33 lines in 8 files changed: 7 ins; 2 del; 24 mod
  Patch: https://git.openjdk.org/valhalla/pull/2541.diff
  Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2541/head:pull/2541

PR: https://git.openjdk.org/valhalla/pull/2541

Reply via email to