On Fri, 12 Jun 2026 15:07:36 GMT, Alan Bateman <[email protected]> wrote:
> The changes to the module system to allow the JDK exploded image support > preview features need a new cleanups. All relatively simple: > > - the factory method to create ModuleFinder that locates modules in a JDK > exploded image is renamed as this is not like the module path specified to > the java launcher or jlink tool. > - the ModuleReader for the exploded image is checking that a located resource > exists twice. > - the ModuleReader::list method does not need to collect all resources when > preview features are disabled or the module does not have any preview classes > - Some cleanups to the test. assertUtf8Resource is renamed to testReader as > it's really testing all the module reader methods. Fixed some resource leaks > and reverted a few random format/comment changes that are nothing to do with > the changes in the branch. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). @AlanBateman Your change (at version 24fd3413b161ba006b906a4326c032e30ac475f5) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2540#issuecomment-4705058808
