On Tue, 16 Jun 2026 17:53:22 GMT, Chen Liang <[email protected]> wrote:
>> The preview note in the class description is re-worked and moved to before >> the paragraph on null key/values. The updated text removes reference to the >> getter methods. Also removes the mention/link to WeakReference as that is >> not introduced until later in the class description. >> >> The long standing Implementation note is updated to replace use of "value >> objects" with "values" and avoid any confusing with Value Objects. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.base/share/classes/java/util/WeakHashMap.java line 108: > >> 106: * from being discarded. Note that a value may refer indirectly to its >> 107: * key via the {@code WeakHashMap} itself; that is, a value obect may >> 108: * strongly refer to some other key object whose associated value, in > > Suggestion: > > * key via the {@code WeakHashMap} itself; that is, a value may > * strongly refer to some other key whose associated value, in Thanks for looking at it closely. The request for keeping "key object" is because it's the term used in the proceeding paragraphs. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2556#discussion_r3425807272
