> 1. `weakCompareAndSetReferenceXxx` in `Unsafe` were delegating to wrong > methods > 2. Replace use of `0` for reference layout with `Unsafe.NON_FLAT_LAYOUT` > 3. Replace use of `31 - Integer.numberOfLeadingZeros(ascale)` with > `numberOfTrailingZeros` > 4. Remove null check for VarHandle getting from NR fields (parity with > ArrayVarHandle and DirectMethodHandle), add missing null check for flat value > var handles > 5. Remove the weird directives and old flags of RecursiveValueClass > > Thanks to @JornVernee and @AlanBateman for spotting these issues. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Some comments from Viktor, more missing use of NON_FLAT_LAYOUT - Merge branch 'lworld' of https://github.com/openjdk/valhalla into cleanup/lw-reviews-0 - Redundant whitespace - Changes from review comments etc. ------------- Changes: - all: https://git.openjdk.org/valhalla/pull/2576/files - new: https://git.openjdk.org/valhalla/pull/2576/files/7e41acd7..da5be85d Webrevs: - full: https://webrevs.openjdk.org/?repo=valhalla&pr=2576&range=01 - incr: https://webrevs.openjdk.org/?repo=valhalla&pr=2576&range=00-01 Stats: 574 lines in 38 files changed: 451 ins; 20 del; 103 mod Patch: https://git.openjdk.org/valhalla/pull/2576.diff Fetch: git fetch https://git.openjdk.org/valhalla.git pull/2576/head:pull/2576 PR: https://git.openjdk.org/valhalla/pull/2576
