On Thu, 25 Jun 2026 10:53:21 GMT, Martin Doerr <[email protected]> wrote:
>> Joel Sikström has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add twi_0 + isync after read_flat_field in templateTable_ppc_64.cpp >> >> Co-authored-by: Martin Doerr <[email protected]> > > src/hotspot/cpu/ppc/templateTable_ppc_64.cpp line 3420: > >> 3418: __ read_flat_field(Rcache, R17_tos); >> 3419: __ verify_oop(R17_tos); >> 3420: // memory barrier in read_flat_field > > I think we should better add > ```C++ > __ twi_0(R17_tos); > __ isync(); > > to be on the safe side. Thank you for the feedback! I added the two instructions in a new commit. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2581#discussion_r3473927824
