On Fri, 26 Jun 2026 08:23:49 GMT, Christian Hagedorn <[email protected]> wrote:
> This PR addresses some small clean-ups as suggested in review comments: > https://github.com/openjdk/jdk/pull/31122#discussion_r3404416714 by > @theRealAph > https://github.com/openjdk/jdk/pull/31122#discussion_r3429286528 by > @TheRealMDoerr > https://github.com/openjdk/jdk/pull/31122#discussion_r3429567374 by @reinrich > https://github.com/openjdk/jdk/pull/31122#discussion_r3438837024 by @dean-long > https://github.com/openjdk/jdk/pull/31122#discussion_r3438840971 by @dean-long > > Thanks, > Christian > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp line 300: > 298: CodeEmitInfo* info = state_for(x, x->state(), true); > 299: LIR_Opr tmp = new_register(T_ADDRESS); > 300: monitor_enter(obj.result(), lock, syncTempOpr(), tmp, Matches mainline src/hotspot/share/runtime/sharedRuntime.cpp line 2933: > 2931: // Fall back to non-scalarized calling convention > 2932: SigEntry::add_entry(_sig_cc, T_OBJECT, ss.as_symbol()); > 2933: SigEntry::add_entry(_sig_cc_ro, T_OBJECT, ss.as_symbol()); Found additionally by @TobiHartmann. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2584#discussion_r3480103581 PR Review Comment: https://git.openjdk.org/valhalla/pull/2584#discussion_r3480109363
