On Mon, 29 Jun 2026 09:27:21 GMT, Viktor Klang <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> move the assertThrows() more closer to the actual
>> readObject()/writeObject() invocation
>
> test/jdk/java/io/Serializable/valueObjects/ValueSerializationTest.java line
> 151:
>
>> 149:
>> 150: Arguments.of(
>> 151: (Object) new ValueWithDeserializer[]{
>
> For maintainability-purposes, it would be good to document why/when the
> arguments to Arguments.of are explicitly cast to (Object) and when not.
Done. I've updated the PR with a code comment explaining this cast, here and a
few other places.
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2590#discussion_r3490699856
