On Tue, 30 Jun 2026 16:13:13 GMT, Quan Anh Mai <[email protected]> wrote:
>> src/hotspot/share/opto/inlinetypenode.cpp line 956:
>>
>>> 954:
>>> 955: // Both must be vk
>>> 956: if (cur_lhs_inline != nullptr && cur_lhs_inline->inline_klass()
>>> == vk) {
>>
>> You can add a comment that it is not an issue if `cur_lhs_inline` is
>> nullable and `cur_lhs_field` is null-checked, it is null-checked so that we
>> can load the fields, and an `InlineTypeNode` does that already.
>
> It's not quite what I want to say. The null check is still present, the thing
> is that we ignored the null-checked value (the `CastPP`) and just use the raw
> value. This is because normally, we need a non-null `CastPP` to load from the
> object. That is unnecessary for an `InlineTypeNode` because we don't perform
> the loads.
Okay, here's a new attempt :slightly_smiling_face:
-------------
PR Review Comment:
https://git.openjdk.org/valhalla/pull/2602#discussion_r3503415625
