On Tue, 30 Jun 2026 16:52:30 GMT, Jaikiran Pai <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 11 additional >> commits since the last revision: >> >> - merge latest from lworld branch >> - @build for test library classes used in the test >> - no need for Arguments >> - Chen's review - switch param order on junit asserts >> - Viktor's reviews >> - adjust test method comment >> - fix comment typo >> - Viktor's review - add code comment in test >> - move the assertThrows() more closer to the actual >> readObject()/writeObject() invocation >> - rename methods >> - ... and 1 more: >> https://git.openjdk.org/valhalla/compare/4846bd8a...1692dbf9 > > I've implemented the review suggestions and updated the PR. The test > continues to pass as expected with these changes. @jaikiran If you don't mind, feel free to integrate; I can add comments to these methods in my followup work. ------------- PR Comment: https://git.openjdk.org/valhalla/pull/2590#issuecomment-4857288909
