On Wed, 1 Jul 2026 11:15:40 GMT, Alan Bateman <[email protected]> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> doc/lw-reflect-preview-api-0 >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> doc/lw-reflect-preview-api-0 >> - Merge branch 'lworld' of https://github.com/openjdk/valhalla into >> doc/lw-reflect-preview-api-0 >> - Reword recommendations >> - Make requireIdentity reflective >> - Reflective preview API behavior out of preview > > src/java.base/share/classes/java/lang/Class.java line 1380: > >> 1378: * the component type is an interface >> 1379: * <li> when preview features are enabled, its {@link >> 1380: * AccessFlag#IDENTITY identity} modifier is always true > > As it's now a link then maybe "identity" should be "IDENTITY". I realize the > other non-link usages are "identity". I saw the other modifier references in lowercase being in code block - like in `{@code public}, {@code protected},` above, so making this "identity" appearance non-code font feels weird. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2578#discussion_r3513823866
